This repository has been archived by the owner on Mar 18, 2021. It is now read-only.
Fixed bug with isNotPresent in partial matcher. #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| extra = []; | ||
| matchState["extra"] = extra; | ||
| if (matchValue is _NotPresentMatcher) { | ||
| if (value != null) { |
There was a problem hiding this comment.
check that item.containsKey(matchKey) == false
| @@ -492,6 +492,7 @@ void main() { | |||
| var response = await defaultTestClient.request("/foo").get(); | |||
| expect(response, hasBody(partial({"foo": "bar"}))); | |||
| expect(response, hasBody(partial({"x": greaterThan(0)}))); | |||
| expect(response, hasBody(partial({"baz": isNotPresent}))); | |||
There was a problem hiding this comment.
split into own test, add test for map that contains {"key" : null}
anachlas
force-pushed
the
an/fixisnotpresent
branch
from
23fbb4f
to
12934be
Compare
anachlas
force-pushed
the
an/fixisnotpresent
branch
from
ce9b9ab
to
ba5e1ca
Compare
| @@ -512,6 +512,33 @@ void main() { | |||
| expect(e.toString(), contains('Body: {"foo":"bar","x":5}')); | |||
| } | |||
| }); | |||
|
|
|||
| test("Partial match, null and not present", () async { | |||
There was a problem hiding this comment.
Is there a success case as well? expect(response, hasBody(partial({"abcd" : isNotPresent}))
There was a problem hiding this comment.
I had it in the other test and I took it out. One sec.
itsjoeconway
pushed a commit
that referenced
this pull request
Dec 1, 2016
* Fixed bug with isNotPresent in partial matcher. * Added a test, caught another bug, fixed the bug. * Check success case.
itsjoeconway
added a commit
that referenced
this pull request
Dec 7, 2016
* Fixing contentType behavior for Response * Fix tests to use content-type * Changing behavior for content type interpretation/handling for Response * Fixed documentation * Fixed docs, fixed style thing * dartfmt * Bump version number, change log * WIP; clean up private/public * Updated test/template projects to use import instead of part, changed data model builder to include lib dependencies * Cleaning up template project * Cleaned up API a bit, hid some things * Moved isolate exception back to public to prevent from breaking existing code, marked as deprecated * dartfmt * Fixed type on app config * Cleaned up example requestsink a smidgen * Revert "Cleaned up example requestsink a smidgen" This reverts commit 6255e4d. * Fixing small thing in template sink * Renaming some things * Made a few static values const * Fixing up some tests, test_all generator * Updated some tests, made the last managedcontext the default context * Removed unused method * Added instructions for running tests and collecting coverage * UPdated change log * Using codecov and adding to travis * Update CHANGELOG.md * Fixed bug with isNotPresent in partial matcher. (#143) * Fixed bug with isNotPresent in partial matcher. * Added a test, caught another bug, fixed the bug. * Check success case. * pr feedback * Jc/fix managed resolution (#147) * Tests and fixes for template generation and data model generation * Fixed some exit code stuff * Updated changelog * dartfmt * Removed unused imports * Jc/explicit query values (#148) * Tests and fixes for template generation and data model generation * Fixed some exit code stuff * dartfmt * Removed unused imports * Disallow multiple query parameters of same key if arg type is not List in HTTPController, allow when is * dartfmt * update changelog * Improve willSendResponse and tests * Fixing some naming and ordering in template (#150) * Fixing some naming and ordering in template * Fixed test issue with 1.21
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #142