Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transfer Auth & optimize some code #69

Merged
merged 3 commits into from
Dec 28, 2020
Merged

transfer Auth & optimize some code #69

merged 3 commits into from
Dec 28, 2020

Conversation

printfcoder
Copy link
Member

@printfcoder printfcoder commented Dec 28, 2020 •
edited
Loading

@printfcoder printfcoder changed the title [WIP] rm useless code transfer Auth & optimize some code Dec 28, 2020
@printfcoder printfcoder removed the WIP label Dec 28, 2020
@printfcoder printfcoder merged commit 935a932 into stack-labs:master Dec 28, 2020
@printfcoder printfcoder mentioned this pull request Dec 28, 2020
Open
hb-chen
hb-chen reviewed Dec 29, 2020
View reviewed changes
cmd/cmd.go
Comment on lines +491 to +494
if err = (*c.opts.Auth).Init(authOpts...); err != nil {
return fmt.Errorf("Error configuring auth: %v ", err)
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要初始化c.opts.Auth

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已处理

hb-chen
hb-chen reviewed Dec 29, 2020
View reviewed changes
cmd/cmd_config.go
opts = append(opts, au.PublicKey(a.PublicKey))
opts = append(opts, au.PrivateKey(a.PrivateKey))

if plugin.LoggerPlugins[a.Name] != nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plugin.AuthPlugins?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hb-chen hb-chen hb-chen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@printfcoder @hb-chen