Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Remove free-disk-space from the build-*-image actions #14

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

NickLarsenNZ
Copy link
Member

There are different paths when running free-disk-space directly in actions from this repository (eg: in smoke tests) vs being called from a remote repository.

There doesn't appear to be an easy way to work around it.

Breaking change

Workflows using the build-product-image or build-container-image actions will need to run free-disk-space explicitly beforehand.

Eg:

    steps:
      # 👇
      - name: Free Disk Space
        uses: stackabletech/actions/free-disk-space@x.x.x
      # ☝️

      - name: Checkout Repository
        uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7

      - name: Build Product Image
        id: build
        uses: stackabletech/actions/build-product-image@x.x.x
        with:
          product-name: ${{ env.PRODUCT_NAME }}
          product-version: ${{ matrix.versions }}
          build-cache-password: ${{ secrets.BUILD_CACHE_NEXUS_PASSWORD }}

Verified

This commit was signed with the committer’s verified signature. The key has expired.
addaleax Anna Henningsen
…path issues when run locally vs remotely

Verified

This commit was signed with the committer’s verified signature. The key has expired.
addaleax Anna Henningsen
@NickLarsenNZ NickLarsenNZ self-assigned this Oct 24, 2024
@NickLarsenNZ NickLarsenNZ requested a review from Techassi October 24, 2024 17:53
@NickLarsenNZ NickLarsenNZ merged commit fe921a9 into main Oct 24, 2024
9 checks passed
@NickLarsenNZ NickLarsenNZ deleted the fix/free-disk-space-path branch October 24, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants