Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add --target-containerfile argument #44

Merged
merged 4 commits into from
Oct 18, 2024
Merged

feat: Add --target-containerfile argument #44

merged 4 commits into from
Oct 18, 2024

Conversation

Techassi
Copy link
Member

This PR adds the ability to customize the target containerfile used, defaults to Dockerfile. This for example allows the use of Containerfile instead of the currently hardcoded Dockerfile.

@Techassi Techassi added release-note Denotes a PR that will be considered when it comes time to generate release notes. type/feature-new labels Oct 11, 2024
@Techassi Techassi self-assigned this Oct 11, 2024
@Techassi Techassi removed the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 11, 2024
@Techassi Techassi marked this pull request as ready for review October 14, 2024 12:10
@Techassi Techassi requested a review from razvan October 15, 2024 06:23
sbernauer
sbernauer approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a small question

src/image_tools/args.py Show resolved Hide resolved
@Techassi Techassi added this pull request to the merge queue Oct 18, 2024
Merged via the queue into main with commit d735687 Oct 18, 2024
4 checks passed
@Techassi Techassi deleted the feat/target-dockerfile-option branch October 18, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbernauer sbernauer sbernauer approved these changes

@razvan razvan Awaiting requested review from razvan

Assignees

@Techassi Techassi

Labels
type/feature-new
Projects
Stackable Engineering
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Techassi @sbernauer