From fbf99218fa84287b2080e5779f38d8a7a464bebc Mon Sep 17 00:00:00 2001 From: dervoeti Date: Wed, 6 Nov 2024 11:03:34 +0100 Subject: [PATCH] fix: only use the hash for the namespace to prevent errors caused by special characters in test case names --- pkg/test/harness.go | 6 +----- pkg/test/harness_test.go | 2 +- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/pkg/test/harness.go b/pkg/test/harness.go index 9eca26b..7ef2ca1 100644 --- a/pkg/test/harness.go +++ b/pkg/test/harness.go @@ -66,11 +66,7 @@ func determineNamespace(testcaseName string) string { hasher.Write([]byte(testcaseName)) hash := hex.EncodeToString(hasher.Sum(nil)) - truncatedFileName := testcaseName - if len(truncatedFileName) > 32 { - truncatedFileName = truncatedFileName[:32] - } - return fmt.Sprintf("kuttl-%s-%s", truncatedFileName, hash[:10]) + return fmt.Sprintf("kuttl-%s", hash[:10]) } // LoadTests loads all of the tests in a given directory. diff --git a/pkg/test/harness_test.go b/pkg/test/harness_test.go index 26396f2..344c976 100644 --- a/pkg/test/harness_test.go +++ b/pkg/test/harness_test.go @@ -90,5 +90,5 @@ func TestAddNodeCaches(t *testing.T) { } func TestDetermineNamespace(t *testing.T) { - assert.Equal(t, "kuttl-smoke_airflow-2.9.2_openshift-fa-c7e64f7a24", determineNamespace("smoke_airflow-2.9.2_openshift-false_executor-kubernetes")) + assert.Equal(t, "kuttl-c7e64f7a24", determineNamespace("smoke_airflow-2.9.2_openshift-false_executor-kubernetes")) }