-
-
Notifications
You must be signed in to change notification settings - Fork 16
fix(webhook): Force apply the CRD in the CRD maintainer #1116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+30
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures the operator will be the sole manager of the CRD (and all its fields) going forward. This avoids running into conflicts when CRDs were previously deployed by helm or stackablectl.
sbernauer
previously approved these changes
Oct 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, works 🥳
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
sbernauer
approved these changes
Oct 31, 2025
Techassi
added a commit
to stackabletech/operator-templating
that referenced
this pull request
Oct 31, 2025
Recent nix versions renamed two fields used in our default.nix file: - buildPlatform has been renamed/moved to stdenv.buildPlatform - hostPlatform has been renamed/moved to stdenv.hostPlatform This came up during the testing of stackabletech/operator-rs#1116 in the secret-operator.
This was referenced Oct 31, 2025
github-merge-queue bot
pushed a commit
to stackabletech/operator-templating
that referenced
this pull request
Oct 31, 2025
* fix(nix): Update default.nix field names Recent nix versions renamed two fields used in our default.nix file: - buildPlatform has been renamed/moved to stdenv.buildPlatform - hostPlatform has been renamed/moved to stdenv.hostPlatform This came up during the testing of stackabletech/operator-rs#1116 in the secret-operator. * chore(nix): Update packages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caution
This is a release blocker. It needs to be included in the secret-operator.
This ensures the operator will be the sole manager of the CRD (and all its fields) going forward. This avoids running into conflicts when CRDs were previously deployed by helm or stackablectl.