feat(animation): Configurable animation motions #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Hey @JoseLion Overall LGTM. I just left a suggestion and a question. Let me know if they make sense.
sebas1208
reviewed
Jan 6, 2023
| @@ -117,7 +123,7 @@ export const SpotlightTourProvider = React.forwardRef<SpotlightTour, SpotlightTo | |||
| ? stop() | |||
| : renderStep(current + 1); | |||
| } | |||
| }, [renderStep, current, steps.length]); | |||
| }, [stop, renderStep, current, steps.length]); | |||
There was a problem hiding this comment.
Just checking if step should also be added as dep?
There was a problem hiding this comment.
No, step is only in renderStep function scope 🙂
sebas1208
reviewed
Jan 6, 2023
This was referenced Feb 7, 2023
Merged
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two new transition motion effects for the spotlight, making a total of 3:
The motion is configurable globally for the whole tour in the props of
<SpotlightTourProvider />, or more granularly, on each step configuration.Aside from this feature, the changes on the PR allowed us to decouple the render and animation of the spotlight and the tooltip components, improving the performance and fixing issue #77.
This PR also adds important improvements to the ESLint configuration, the codebase perse, and the tests.