From c78922b71dfede456154bb39077064446f8bb4b8 Mon Sep 17 00:00:00 2001
From: sd109 <scott@stackhpc.com>
Date: Fri, 12 Jul 2024 10:59:48 +0100
Subject: [PATCH] Use Azimuth UI schema for integer constraint

---
 chart/azimuth-ui.schema.yaml | 6 ++++++
 chart/values.schema.json     | 4 ++--
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/chart/azimuth-ui.schema.yaml b/chart/azimuth-ui.schema.yaml
index 7ac26d3..c31af4b 100644
--- a/chart/azimuth-ui.schema.yaml
+++ b/chart/azimuth-ui.schema.yaml
@@ -10,6 +10,12 @@ controls:
     type: MirrorControl
     path: /huggingface/model
     visuallyHidden: true
+  # Azimuth UI doesn't handle json type ["integer","null"]
+  # properly so we allow type "string" in JSON schema then
+  # constrain to (optional) integer here.
+  /api/modelMaxContextLength:
+    type: IntegerControl
+    required: false
 
 sortOrder:
   - /huggingface/model
diff --git a/chart/values.schema.json b/chart/values.schema.json
index f99323e..4bac93d 100644
--- a/chart/values.schema.json
+++ b/chart/values.schema.json
@@ -97,7 +97,7 @@
             "type": "object",
             "properties": {
                 "modelMaxContextLength": {
-                    "type": ["integer", "null"],
+                    "type": "string",
                     "title": "Model Context Length",
                     "description": "An override for the maximum context length to use if the model's default is not suitable."
                 },
@@ -106,7 +106,7 @@
                     "properties": {
                         "version": {
                             "type": "string",
-                            "title": "vLLM version override",
+                            "title": "Backend vLLM version",
                             "description": "The vLLM version to use as a backend. Must be a version tag from [this list](https://github.com/vllm-project/vllm/tags)",
                             "default": "v0.4.3"
                         }