Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimise Profiler #128

Open
stackotter opened this issue Sep 10, 2022 · 5 comments
Open

Optimise Profiler #128

stackotter opened this issue Sep 10, 2022 · 5 comments
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest

Comments

@stackotter
Copy link
Owner

Fixing this issue will give you an introduction to optimising Swift code. If you have no idea where to start, ask on the Discord server and I'll give you some tips and tricks.

Given that the Profiler is used mostly in performance critical places, it would be useful to make it as optimised as possible so that readings are as accurate as possible (if it's too slow it starts noticeably affecting its own readings when nesting).

@stackotter stackotter added bug Something isn't working good first issue Good for newcomers labels Sep 10, 2022
@stackotter
Copy link
Owner Author

Some initial tips to get you started:

  • Reserve capacity for a collection if you have an approximate idea of how many elements it will have
  • Move repeated calculations out of loops
  • Cache results if it makes sense
  • See OptimizationTips in the official Swift repo for further tips

@japanese-goblinn
Copy link
Contributor

@stackotter Hey, can you assign me on this one?

@japanese-goblinn
Copy link
Contributor

Hi, sorry, have no time recently to work on this. Now when i've been laid off from my current job I've more free time 🤡

@stackotter
Copy link
Owner Author

stackotter commented Nov 16, 2022

Hi, sorry, have no time recently to work on this. Now when i've been laid off from my current job I've more free time 🤡

I'm sorry to hear that man :( I wish you the best in finding a new job! Delta Client is of course second priority to anything else that comes up in your life, so no pressure to complete this task anytime soon

I'm excited for you to contribute again, your first contribution was super useful! Let me know if I can help out with anything

@stackotter
Copy link
Owner Author

@japanese-goblinn let me know if you want me to assign you again, I'm just going through and unassigning issues that haven't been touched in a while

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants