Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View bobbing #130

Open
stackotter opened this issue Sep 12, 2022 · 0 comments
Open

View bobbing #130

stackotter opened this issue Sep 12, 2022 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@stackotter
Copy link
Owner

At the moment the camera is attached directly to the player's position. View bobbing would be implemented by adding some offset calculated from (presumably) the player's velocity and the current time using sine and cosine functions. To confirm this it would be best to look at the decompiled vanilla sources for the specifics.

The best place to implement this would be in getCameraUniforms at the bottom of RenderCoordinator.swift. Eventually more of the camera based calculations should be refactored out of RenderCoordinator for neatness, but it's fine to just add it on to the end for now.

@stackotter stackotter added bug Something isn't working good first issue Good for newcomers labels Sep 12, 2022
@stackotter stackotter added enhancement New feature or request and removed bug Something isn't working labels Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant