Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement remaining chat input handling #160

Open
2 of 8 tasks
stackotter opened this issue Jan 8, 2023 · 6 comments · Fixed by #172 or #173
Open
2 of 8 tasks

Implement remaining chat input handling #160

stackotter opened this issue Jan 8, 2023 · 6 comments · Fixed by #172 or #173
Labels
enhancement New feature or request

Comments

@stackotter
Copy link
Owner

stackotter commented Jan 8, 2023

It's easiest to explain this with an example. If you click the up arrow while writing a chat message, the game crashes (because it tries to render an up arrow) whereas it should replace the current text with the previous message that the user sent.

The main tasks are:

  • Support up and down arrow keys (to reuse previous messages/commands)
  • Support left and right arrow keys (to navigate message input)
  • Support using the shift key to highlight text along with the arrow keys
  • Support cmd+x to cut the selection and cmd+c to copy the selection
  • Support cmd+a to select all of the text
  • Support backspacing selections
  • Probably more that I haven't thought of yet

Additional:

  • The cursor blinking timer should restart every time the cursor moves (instead of purely being based on CFAbsoluteTimeGetCurrent)
@stackotter stackotter added the enhancement New feature or request label Jan 8, 2023
@U5KUN
Copy link

U5KUN commented Aug 5, 2023

  • Support Japanese and Chinese etc.
  • Support _ key

@jmshgs
Copy link
Contributor

jmshgs commented Aug 5, 2023

  • Support Japanese and Chinese etc.

this has more to do with localization and should be in a separate issue

@stackotter
Copy link
Owner Author

  • Support Japanese and Chinese etc.
  • Support _ key

Do you mean supporting the japanese and chinese languages for localisation? or just supporting japanese and chinese characters in chat? (which I thought I fixed, but maybe I didn't)

@stackotter
Copy link
Owner Author

GitHub closed the issue automatically when the PR was closed (because the PR referenced the issue), but the PR only addresses part of the issue so I'm reopening.

@stackotter
Copy link
Owner Author

  • Support Japanese and Chinese etc.
  • Support _ key

I've added full unicode support so Japanese and Chinese characters should now work (I tested some hiragana and it seems to be working correctly).

What do you mean by 'support _ key'?

@stackotter
Copy link
Owner Author

Another PR closed the issue again, whoops 😅 It completes one of the subtasks not the whole things

@stackotter stackotter reopened this Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants