Clarity wasm runtime #3880
Clarity wasm runtime #3880
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/2.4-clarity-wasm #3880 +/- ##
======================================================
Coverage 58.31% 58.31%
======================================================
Files 1 1
Lines 571 571
======================================================
Hits 333 333
Misses 238 238 ☔ View full report in Codecov by Sentry. |
Handle passing arguments into a contract call using the Wasm runtime and handle returning a value from the contract call.
The pass that initializes a contract should have the contract analysis available, but when a contract is being called, only use the `ContractContext`. This requires adding the return type of a function to this context.
obycode
force-pushed
the
feat/clarity-wasm-runtime
branch
from
b658241
to
2a254f7
Compare
obycode
changed the base branch from
feat/clarity-wasm
to
feat/2.4-clarity-wasm
This comment clarifies that this function should not be used during normal execution.
All error cases should be properly handled and generate an error to be handled by the caller. Any `Wasm` errors should never happen in production and would indicate an implementation problem if they show up.
clarity/src/vm/clarity_wasm.rs
Outdated
| "clarity", | ||
| "define_function", | ||
| |mut _caller: Caller<'_, T>, _kind: i32, _name_offset: i32, _name_length: i32| { | ||
| // FIXME: I don't understand why I have to write this like this |
There was a problem hiding this comment.
Yes I do, it's a bit tricky.
The closure here should implement IntoFunc. For the arguments, no issue, but for the return type, here you are returning a Result, which does not implement WasmRet.
What does implement WasmRet however is WasmTime::Result, which they say is a wrapper for Result<T, anyhow::Error.
So if I add anyhow as dep and rewrite the closure like this, it works:
|mut _caller: Caller<'_, T>, _kind: i32, _name_offset: i32, _name_length: i32| {
Err::<(), _>(anyhow!(Error::Wasm(WasmError::DefineFunctionCalledInRunMode)))
}Why it worked with a ? is because this calls an implicit "into" on the error, converting it automatically to a anyhow::Error.
Also, I had to specify the type for Err, since we don't have the Ok(()) anymore, and the compiler cannot infer the complete type for the Result.
Co-authored-by: Acaccia <anthonycaccia24@gmail.com>
For an `optional`, do not try to create a value unless the indicator is `1`. Similarly, for `response`, do not try to create a value from the `ok` value if the indicator is `0` or from the `err` value if the indicator is `1`.
Added a bool to specify whether or not the representation (offset + length) should be included in the size for in-memory values.
This is the return value from the last expression at the top-level of the contract.
There are now tests for the functions that read and write the Wasm memory!
This includes `keccak256`, `sha512`, and `sha512/256`.
This function is useful for debugging wasm code.
|
|
|
Replaced by #4093 |
This is a WIP and not intended to be merged.