Clarity-Wasm: fix for the print host function #5135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Acaccia
requested changes
Sep 9, 2024
clarity/src/vm/clarity_wasm.rs
Outdated
| value_length: i32, | ||
| _serialized_ty_offset: i32, | ||
| _serialized_ty_length: i32| { | ||
| // NOTE: _serialized_ty_offset and _serialized_ty_length are used in `stacks-network/clarity-wasm`, here we only care about the function stub |
There was a problem hiding this comment.
This isn't completely true. The function here would be called if it's the consequence of a contract-call?. So if we want to keep a coherence between functions called directly or from another contract, we have to duplicate it until the duplication issue is solved.
There was a problem hiding this comment.
I missed that, sorry! Copied all the code (and tested with a contract call, I'll add the test to the other PR).
The only relevant delta is the removal of the dev mode debug from here, as it wasn't present in the clarity-wasm code.
There was a problem hiding this comment.
No need for the contract-call? test: hopefully, someone will fix the duplication issue at some point...
Acaccia
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stacks-core part of stacks-network/clarity-wasm#501 -- because of code duplication, on contract call the signature for linked functions are imported from stacks-core.