Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Reloader dployment keeps out-of-sync in ArgoCD #769

Closed
lesomnus opened this issue Oct 15, 2024 · 7 comments
Closed

[BUG] Reloader dployment keeps out-of-sync in ArgoCD #769

lesomnus opened this issue Oct 15, 2024 · 7 comments
Labels
kind/bug Something isn't working

Comments

@lesomnus
Copy link

Describe the bug
Deployment of reloader keeps out-of-sync state after sync.

To Reproduce

apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization

namespace: reloader
resources:
  - https://github.com/stakater/Reloader/deployments/kubernetes/?ref=v1.1.0

patches:
  - patch: |-
      apiVersion: apps/v1
      kind: Deployment
      metadata:
        name: reloader-reloader
        annotations:
          argocd.argoproj.io/sync-options: Replace=false
      spec:
        template:
          spec:
            containers:
              - name: reloader-reloader
                image: ghcr.io/stakater/reloader:v1.1.0
                args:
                  - --reload-strategy=annotations

Expected behavior
Remain in sync state.

Screenshots
If applicable, add screenshots to help explain your problem.

Environment

  • Operator Version: v1.1.0
  • Kubernetes Version: v1.30.5+k3s1
  • ArgoCD Version: v0.4.17

Additional context
I have tried #333 but doesn't work...

Reloader does not print any logs something like: "detects something is changed so restarted something".

@lesomnus lesomnus added the kind/bug Something isn't working label Oct 15, 2024
@MuneebAijaz
Copy link
Contributor

hi @lesomnus, can you share what part of reloader deployment stays out of sync pls?

@lesomnus
Copy link
Author

lesomnus commented Oct 15, 2024

Im not sure that Deployment/reloader-reloader (is this what you menat by "part"?) is the cause of out-of-sync, but ArgoCD shows it is out of sync.

Just for the note, ArgoCD reports some resource is out-of-sync if the deployed resource is not same as the resourec definition from the remote repository (Helm or Git).

Current situation:

  1. Deploy Reloader to ArgoCD using kustomization.
  2. Deployed and ArgoCD reports the state is in "sync".
  3. After some seconds, it became "out-of=sync" state.
  4. ArgoCD starts sync process, Deployment got chaned to sync with repository (but Im not sure which field is changed).
  5. go 2, repeat.

@MuneebAijaz
Copy link
Contributor

Argocd can show the difference between the live state and the desired state in its UI, I was referring to that screenshot/manifest details. So, i want to see which fields of the reloader deployment are out of sync.

This blog shows how to view the diff details in argocd. https://codefresh.io/blog/argo-cd-preview-diff/

@MuneebAijaz
Copy link
Contributor

I will try to replicate it on end meanwhile

@lesomnus
Copy link
Author

image

Oh, I didn't know there was a feature to view the diff.

@MuneebAijaz
Copy link
Contributor

Your issue relates to this PR #742 (comment), fix has been merged. but we havent released a proper version for it yet. We will target it for this week. 😃

@lesomnus
Copy link
Author

fixed the problem, thanks for the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants