Add eslint to project and fix problems

[antonilol]

closes #286

[antonilol]

ts complains that mediaKeyMap can be undefined because it is only set if (m.type === constants.message_types.attachment)

chatTribes.ts lines 682-683

[antonilol]

note: bot_id changed from string to any

[antonilol]

( 292449e ) the script can be found on https://github.com/antonilol/sphinx-relay/tree/model-typer

[antonilol]

src/notify.ts:105:17 - error TS2339: Property 'blocked' does not exist on type 'Contact'.

105       if (other.blocked) return

add it?

[antonilol]

src/scopes.ts:22:22 - error TS2339: Property 'scope' does not exist on type 'JwtBody'.

22   const scopes = jwt.scope.split(',')

this function is given a JwtBody elsewhere in the repo so i assigned that type to the parameter but ts is not happy

[antonilol]

there are a lot of errors when running npm run build. lots of them are caused by ts not knowing Model.update (where model is Message or Chat etc)
how to fix this?

[antonilol]

oops wrong button

[antonilol]

In file helpers.ts
On line 265 owner is checked if it is undefined, and then reassigned with a Contact.dataValues. note that after the if block owner can be a Contact or Contact.dataValues. on line 279 owner.dataValues is passed into a function. This can be a Contact.dataValues.dataValues, that's undefined, right?

[Evanfeenstra]

In file helpers.ts On line 265 owner is checked if it is undefined, and then reassigned with a Contact.dataValues. note that after the if block owner can be a Contact or Contact.dataValues. on line 279 owner.dataValues is passed into a function. This can be a Contact.dataValues.dataValues, that's undefined, right?

Right, 269 shouldn't have the .dataValues. However this code is many month old and has never caused an issue (I think dat.owner is always defined), so possibly the problem is somewhere else

[antonilol]

Maybe dat.owner only is undefined in some test case, because the logs kevin sent show an undefined owner being passed in a function (property id of undefined)

[antonilol]

or Payload.owner is a Contact.dataValues
why is the owner.dataValues passed into the function and not owner?

[antonilol]

https://github.com/stakwork/sphinx-relay/blob/master/src/tests/controllers/clearAllChats.test.ts#L30-L31
chats is a Chat[], c (from the asyncForEach) is the entry value, so Chat and is passed in a function that needs a number
looking at the logs of the test it doesn't get here (so if there are errors here, they simply dont appear)

alice had no chats
bob had no chats
carol had no chats

i changed it to c.id (the argument is chatID)

[antonilol]

will be merging and resolving conflicts here to have a diff of all this work between master every now and then when kevin merges a part with e.g. #307
but cant push atm super annoying

Enumerating objects: 258, done.
Counting objects: 100% (258/258), done.
Delta compression using up to 12 threads
Compressing objects: 100% (87/87), done.
Writing objects: 100% (88/88), 17.92 KiB | 2.99 MiB/s, done.
Total 88 (delta 74), reused 0 (delta 0), pack-reused 0
remote: Resolving deltas: 100% (74/74), completed with 74 local objects.
remote: Internal Server Error
To github.com:antonilol/sphinx-relay.git
 ! [remote rejected]   eslint -> eslint (Internal Server Error)
error: failed to push some refs to 'github.com:antonilol/sphinx-relay.git'

[kevkevinpal]

closing this PR since we've got a system working for eslint now where we decrement the warning count and slowly make our way down