Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warnings count to 466 #377

Merged
merged 1 commit into from
Jul 26, 2022
Merged

warnings count to 466 #377

merged 1 commit into from
Jul 26, 2022

Conversation

antonilol
Copy link
Contributor

@antonilol antonilol commented May 25, 2022

parts of #338 that have test coverage + dev depends from #287

@antonilol
Copy link
Contributor Author

antonilol commented May 25, 2022

@antonilol antonilol force-pushed the eslint-2 branch 2 times, most recently from dba80e6 to b6a7b88 Compare May 25, 2022 11:41
@antonilol antonilol marked this pull request as draft May 25, 2022 11:46
@antonilol
Copy link
Contributor Author

running all tests on each @types dependency to find where the errors come from https://github.com/antonilol/sphinx-relay/pulls

@antonilol antonilol force-pushed the eslint-2 branch 2 times, most recently from 1d72be9 to 35d829d Compare May 25, 2022 15:05
@antonilol
Copy link
Contributor Author

antonilol commented May 25, 2022

all tests were successful and adding the dependencies here did not give any errors, but previously it did so there must have been some outside things causing this, but anyway, All checks have passed

@kevkevinpal
Copy link
Contributor

Other than the one comment and the merge conflicts this PR seems fine to me and I'm good to merge

@Evanfeenstra let me know if you have any comments

@antonilol
Copy link
Contributor Author

i rebased and fixed conflicts, but it gave an extra warning, so fixed 4 simple ones in utils/gitinfo.ts

@kevkevinpal
Copy link
Contributor

seems like a new a new error in the tests

src/utils/cert.ts:208:9 - error TS2322: Type 'KeyPair' is not assignable to type '{ [k: string]: string; }'.
  Index signature for type 'string' is missing in type 'KeyPair'.

208   const transportTokenKeys: { [k: string]: string } = await rsa.genKeys()

@antonilol
Copy link
Contributor Author

seems like a new a new error in the tests

src/utils/cert.ts:208:9 - error TS2322: Type 'KeyPair' is not assignable to type '{ [k: string]: string; }'.
  Index signature for type 'string' is missing in type 'KeyPair'.

208   const transportTokenKeys: { [k: string]: string } = await rsa.genKeys()

oh oops that was 'the missing warning', probably some code got moved, fixed now

@antonilol antonilol changed the title warnings count to 470 warnings count to 466 Jul 26, 2022
@kevkevinpal
Copy link
Contributor

LGTM 🚀

@Evanfeenstra I'm merging now but lemme know if you see anything that you'd like to change

@kevkevinpal kevkevinpal merged commit 71a3c5c into stakwork:master Jul 26, 2022
@antonilol antonilol deleted the eslint-2 branch July 26, 2022 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants