-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
warnings count to 466 #377
Conversation
two |
dba80e6
to
b6a7b88
Compare
running all tests on each |
1d72be9
to
35d829d
Compare
all tests were successful and adding the dependencies here did not give any errors, but previously it did so there must have been some outside things causing this, but anyway, |
d0ce46b
to
ba65b97
Compare
Other than the one comment and the merge conflicts this PR seems fine to me and I'm good to merge @Evanfeenstra let me know if you have any comments |
i rebased and fixed conflicts, but it gave an extra warning, so fixed 4 simple ones in utils/gitinfo.ts |
seems like a new a new error in the tests
|
oh oops that was 'the missing warning', probably some code got moved, fixed now |
LGTM 🚀 @Evanfeenstra I'm merging now but lemme know if you see anything that you'd like to change |
parts of #338 that have test coverage + dev depends from #287