Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix eslint command glob pattern #445

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Conversation

antonilol
Copy link
Contributor

the pattern ./src/*.ts ./src/**/*.ts only matches *.ts in src and 1 directory deeper (because npm script dont have bash globstar enabled)
apparently you can give eslint a directory and it takes all files from it, recursively, so 2 files that were more that 1 directory deep in src have now also been auto-fixed and are included in the warning count

@antonilol
Copy link
Contributor Author

btw, while busy with eslint i thought about this bounty. can i still get it for pr #377? (51 warns)

@antonilol
Copy link
Contributor Author

just rebased this pr

@kevkevinpal kevkevinpal merged commit 3079d50 into stakwork:master Oct 19, 2022
@antonilol antonilol deleted the fix-eslint branch October 20, 2022 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants