Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Search Feature #59

Merged
merged 8 commits into from
Sep 2, 2021
Merged

Improved Search Feature #59

merged 8 commits into from
Sep 2, 2021

Conversation

stanleyowen
Copy link
Owner

@stanleyowen stanleyowen commented Aug 30, 2021

Resolved / Related Issues
Items resolved / related issues by this PR.

Details of Changes
Add details of changes here.

  • Restructure Search Variable
  • Added Custom Algorithm to Search Data
  • Randomize Data after Fetching Data from Server

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots (optional)
Add screenshots here.

@netlify
Copy link

netlify bot commented Aug 30, 2021

✔️ Deploy Preview for lofi-players ready!

🔨 Explore the source changes: 3a93510

🔍 Inspect the deploy log: https://app.netlify.com/sites/lofi-players/deploys/61303fb1b487ab0007a1d08c

😎 Browse the preview: https://deploy-preview-59--lofi-players.netlify.app/

@stanleyowen stanleyowen self-assigned this Aug 30, 2021
@stanleyowen stanleyowen added the enhancement New feature or request label Aug 30, 2021
@stanleyowen stanleyowen marked this pull request as ready for review September 1, 2021 08:57
Copy link
Collaborator

@kimlimjustin kimlimjustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if you notice this or no, but the preview link doesn't work.

@kimlimjustin kimlimjustin added the changes requested Changes are needed for this pull request label Sep 1, 2021
@stanleyowen
Copy link
Owner Author

Good catch! I'll soon working on this issue, thanks!

@stanleyowen stanleyowen removed the changes requested Changes are needed for this pull request label Sep 2, 2021
@stanleyowen stanleyowen merged commit bfe2675 into next Sep 2, 2021
@stanleyowen stanleyowen added the implemented Feature is implemented and shipped to production label Sep 2, 2021
@stanleyowen stanleyowen deleted the search branch September 2, 2021 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request implemented Feature is implemented and shipped to production
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants