[cleanup] Do some rename and cleanup #2319

jolestar · 2021-03-24T05:00:32Z

No description provided.

github-actions · 2021-03-24T05:32:43Z

Benchmark for `ae23db8`

Click to view benchmark

Test	PR Benchmark	Master Benchmark	%
accumulator_append	1194.6±63.18µs	1191.2±69.49µs	+0.29%
block_apply/block_apply_10	361.7±2.64ms	362.0±3.27ms	-0.08%
block_apply/block_apply_1000	38.0±0.08s	38.0±0.08s	0.00%
get_with_proof/db_store	42.4±0.33µs	41.8±0.81µs	+1.44%
get_with_proof/mem_store	33.2±3.06µs	32.2±0.80µs	+3.11%
put_and_commit/db_store/1	516.7±26.31µs	532.4±21.84µs	-2.95%
put_and_commit/db_store/10	1516.1±95.91µs	1506.0±100.76µs	+0.67%
put_and_commit/db_store/100	9.1±0.36ms	9.1±0.43ms	0.00%
put_and_commit/db_store/5	978.0±78.70µs	979.7±83.37µs	-0.17%
put_and_commit/db_store/50	5.2±0.21ms	5.2±0.24ms	0.00%
put_and_commit/mem_store/1	71.6±4.19µs	71.6±3.62µs	0.00%
put_and_commit/mem_store/10	630.0±33.22µs	629.2±30.33µs	+0.13%
put_and_commit/mem_store/100	6.0±0.52ms	6.1±0.57ms	-1.64%
put_and_commit/mem_store/5	327.5±16.98µs	322.8±16.55µs	+1.46%
put_and_commit/mem_store/50	3.0±0.14ms	3.1±0.12ms	-3.23%
query_block/query_block_in(10)_times(100)	3.2±0.08ms	3.2±0.05ms	0.00%
query_block/query_block_in(10)_times(1000)	32.3±0.32ms	32.4±0.84ms	-0.31%
query_block/query_block_in(10)_times(10000)	321.9±5.36ms	321.4±3.94ms	+0.16%
query_block/query_block_in(1000)_times(100)	1330.0±4.72µs	1314.9±6.86µs	+1.15%
query_block/query_block_in(1000)_times(1000)	13.2±0.04ms	13.2±0.11ms	0.00%
query_block/query_block_in(1000)_times(10000)	131.5±0.60ms	132.0±0.73ms	-0.38%
storage_transaction	12.6±0.74ms	12.6±0.82ms	0.00%
vm/transaction_execution/1	378.5±1.09ms	378.3±0.94ms	+0.05%
vm/transaction_execution/10	122.2±0.46ms	121.7±0.71ms	+0.41%
vm/transaction_execution/20	113.6±0.59ms	113.4±0.61ms	+0.18%
vm/transaction_execution/5	148.4±0.55ms	149.2±0.69ms	-0.54%
vm/transaction_execution/50	129.3±0.90ms	129.4±0.55ms	-0.08%

github-actions · 2021-03-24T06:27:27Z

Benchmark for `b5c7280`

Click to view benchmark

Test	PR Benchmark	Master Benchmark	%
accumulator_append	1252.9±501.46µs	1203.7±81.84µs	+4.09%
block_apply/block_apply_10	365.3±6.79ms	370.1±25.56ms	-1.30%
block_apply/block_apply_1000	38.2±0.12s	38.1±0.09s	+0.26%
get_with_proof/db_store	42.4±1.12µs	42.4±0.55µs	0.00%
get_with_proof/mem_store	32.5±0.52µs	32.7±0.57µs	-0.61%
put_and_commit/db_store/1	535.4±30.64µs	524.1±26.13µs	+2.16%
put_and_commit/db_store/10	1584.2±85.36µs	1604.5±57.31µs	-1.27%
put_and_commit/db_store/100	9.4±0.75ms	9.2±0.37ms	+2.17%
put_and_commit/db_store/5	970.0±86.34µs	2.0±9.07ms	-51.50%
put_and_commit/db_store/50	5.2±0.24ms	5.2±0.25ms	0.00%
put_and_commit/mem_store/1	72.2±3.68µs	73.3±3.61µs	-1.50%
put_and_commit/mem_store/10	644.6±29.88µs	641.4±31.71µs	+0.50%
put_and_commit/mem_store/100	6.1±0.54ms	6.1±0.56ms	0.00%
put_and_commit/mem_store/5	329.0±17.97µs	336.6±45.27µs	-2.26%
put_and_commit/mem_store/50	3.0±0.12ms	3.1±0.12ms	-3.23%
query_block/query_block_in(10)_times(100)	3.2±0.08ms	3.3±0.06ms	-3.03%
query_block/query_block_in(10)_times(1000)	32.0±0.39ms	32.9±0.52ms	-2.74%
query_block/query_block_in(10)_times(10000)	322.8±3.90ms	326.2±6.47ms	-1.04%
query_block/query_block_in(1000)_times(100)	1302.6±6.65µs	1316.3±7.11µs	-1.04%
query_block/query_block_in(1000)_times(1000)	13.2±0.36ms	13.3±0.06ms	-0.75%
query_block/query_block_in(1000)_times(10000)	131.3±0.44ms	133.0±0.71ms	-1.28%
storage_transaction	11.9±0.74ms	12.1±0.63ms	-1.65%
vm/transaction_execution/1	381.3±3.41ms	380.6±1.56ms	+0.18%
vm/transaction_execution/10	123.0±0.50ms	128.6±10.48ms	-4.35%
vm/transaction_execution/20	114.3±0.44ms	114.5±1.34ms	-0.17%
vm/transaction_execution/5	148.6±0.57ms	150.3±2.01ms	-1.13%
vm/transaction_execution/50	131.2±1.99ms	129.8±0.47ms	+1.08%

codecov · 2021-03-24T08:35:03Z

Codecov Report

Merging #2319 (211488c) into master (2f50c0d) will increase coverage by 0.57%.
The diff coverage is 33.34%.

@@            Coverage Diff             @@
##           master    #2319      +/-   ##
==========================================
+ Coverage   33.21%   33.77%   +0.57%     
==========================================
  Files         478      477       -1     
  Lines       41005    41004       -1     
  Branches    18275    18276       +1     
==========================================
+ Hits        13615    13845     +230     
+ Misses      14000    13325     -675     
- Partials    13390    13834     +444

Flag	Coverage Δ
unittests	`33.77% <33.34%> (+0.57%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
account/service/src/account_events.rs	`41.03% <ø> (ø)`
account/service/src/lib.rs	`100.00% <ø> (ø)`
account/service/src/service.rs	`22.23% <ø> (ø)`
account/src/account.rs	`36.21% <ø> (ø)`
account/src/account_manager.rs	`42.77% <ø> (ø)`
account/src/account_storage.rs	`45.79% <ø> (ø)`
account/src/account_test.rs	`10.76% <ø> (ø)`
account/src/lib.rs	`100.00% <ø> (ø)`
chain/mock/src/mock_chain.rs	`34.89% <ø> (ø)`
chain/open-block/src/lib.rs	`30.35% <ø> (ø)`
... and 92 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f50c0d...211488c. Read the comment docs.

github-actions · 2021-03-24T08:54:35Z

Benchmark for `4b3f036`

Click to view benchmark

Test	PR Benchmark	Master Benchmark	%
accumulator_append	1575.3±124.15µs	1911.8±300.56µs	-17.60%
block_apply/block_apply_10	420.5±11.32ms	445.0±21.58ms	-5.51%
block_apply/block_apply_1000	46.4±2.60s	47.4±4.04s	-2.11%
get_with_proof/db_store	46.5±2.76µs	48.2±4.45µs	-3.53%
get_with_proof/mem_store	37.9±2.46µs	37.5±1.62µs	+1.07%
put_and_commit/db_store/1	725.5±51.43µs	803.2±71.80µs	-9.67%
put_and_commit/db_store/10	1903.9±230.55µs	2.1±0.23ms	-9.34%
put_and_commit/db_store/100	10.1±1.04ms	10.2±0.68ms	-0.98%
put_and_commit/db_store/5	1251.0±107.90µs	1301.8±211.23µs	-3.90%
put_and_commit/db_store/50	7.1±0.89ms	7.8±0.89ms	-8.97%
put_and_commit/mem_store/1	80.5±7.66µs	110.0±19.53µs	-26.82%
put_and_commit/mem_store/10	701.7±41.80µs	698.2±67.71µs	+0.50%
put_and_commit/mem_store/100	6.8±0.49ms	8.4±0.89ms	-19.05%
put_and_commit/mem_store/5	377.5±32.84µs	354.1±25.52µs	+6.61%
put_and_commit/mem_store/50	3.6±0.34ms	3.6±0.54ms	0.00%
query_block/query_block_in(10)_times(100)	3.8±0.15ms	3.4±0.11ms	+11.76%
query_block/query_block_in(10)_times(1000)	36.6±1.18ms	33.2±1.08ms	+10.24%
query_block/query_block_in(10)_times(10000)	364.8±15.40ms	341.8±14.78ms	+6.73%
query_block/query_block_in(1000)_times(100)	1604.5±66.77µs	2.1±0.12ms	-23.60%
query_block/query_block_in(1000)_times(1000)	15.8±0.91ms	17.8±2.31ms	-11.24%
query_block/query_block_in(1000)_times(10000)	152.3±4.21ms	187.1±16.63ms	-18.60%
storage_transaction	20.8±6.29ms	22.6±2.59ms	-7.96%
vm/transaction_execution/1	428.0±10.36ms	447.8±32.67ms	-4.42%
vm/transaction_execution/10	135.7±7.14ms	136.2±5.96ms	-0.37%
vm/transaction_execution/20	142.5±29.47ms	183.4±14.98ms	-22.30%
vm/transaction_execution/5	200.0±30.35ms	195.2±14.27ms	+2.46%
vm/transaction_execution/50	158.3±14.24ms	184.5±35.04ms	-14.20%

* [cleanup] Rename sync2 to sync. * [cleanup] fix typo Refiled to Prefilled * [cleanup] move core/accumulator to commons * [cleanup] cleanup jellyfish merkle dep * [cleanup] move forkable-jellyfish-merkle to commons. * [cleanup] remove core/traits crate. * [cleanup] move core/genesis to genesis. * [cleanup] move account/lib to account

jolestar requested review from nanne007 and tiangong3624749 March 24, 2021 05:00

jolestar force-pushed the feature/cleanup branch from 7a05a55 to f5ee852 Compare March 24, 2021 05:55

jolestar added 8 commits March 24, 2021 16:03

[cleanup] Rename sync2 to sync.

476c398

[cleanup] fix typo Refiled to Prefilled

23e5f3e

[cleanup] move core/accumulator to commons

dd4c97b

[cleanup] cleanup jellyfish merkle dep

6f107e8

[cleanup] move forkable-jellyfish-merkle to commons.

96b0ed7

[cleanup] remove core/traits crate.

2051d18

[cleanup] move core/genesis to genesis.

fcef2c4

[cleanup] move account/lib to account

211488c

jolestar force-pushed the feature/cleanup branch from f5ee852 to 211488c Compare March 24, 2021 08:03

nanne007 approved these changes Mar 24, 2021

View reviewed changes

nanne007 merged commit 4bb9c51 into master Mar 24, 2021

nanne007 deleted the feature/cleanup branch March 24, 2021 09:37

jolestar mentioned this pull request Mar 24, 2021

1.0 cleanup and rework #1745

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[cleanup] Do some rename and cleanup #2319

[cleanup] Do some rename and cleanup #2319

jolestar commented Mar 24, 2021

github-actions bot commented Mar 24, 2021

github-actions bot commented Mar 24, 2021

codecov bot commented Mar 24, 2021

github-actions bot commented Mar 24, 2021

[cleanup] Do some rename and cleanup #2319

[cleanup] Do some rename and cleanup #2319

Conversation

jolestar commented Mar 24, 2021

github-actions bot commented Mar 24, 2021

Benchmark for ae23db8

github-actions bot commented Mar 24, 2021

Benchmark for b5c7280

codecov bot commented Mar 24, 2021

Codecov Report

github-actions bot commented Mar 24, 2021

Benchmark for 4b3f036

Benchmark for `ae23db8`

Benchmark for `b5c7280`

Benchmark for `4b3f036`