new wallet storage and impl #998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanne007
force-pushed
the
feature/new-wallet
branch
2 times, most recently
from
1780351 to
d6d6cf9
Compare
jolestar
reviewed
Jul 30, 2020
客户端维护？ |
nanne007
force-pushed
the
feature/new-wallet
branch
from
d6d6cf9 to
4fb87f4
Compare
jolestar
reviewed
Jul 30, 2020
| fn submit_transaction(&self, txn: SignedUserTransaction) -> Result<()>; | ||
| } | ||
|
|
||
| pub trait RichWallet { |
There was a problem hiding this comment.
这里面的 trait 暂时没用。名字可以忽略。
目前没有抽象接口。
我是想等功能完整后，看看那些需要抽离出来。
| Ok(wallet) | ||
| } | ||
|
|
||
| pub fn unlock_wallet( |
There was a problem hiding this comment.
有 unlock 也需要支持 lock 吧，原来这个逻辑没有加上。
jolestar
approved these changes
Jul 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve first step of #878