Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend README update to add PR checks list #443

Merged
3 commits merged into from
Jul 31, 2022

Conversation

JackDawson94
Copy link
Contributor

Got frustrated that there is no PR doc for people who only contribute to frontend.
So I added a few lines to the README

@JackDawson94
Copy link
Contributor Author

Updated based on your comments.

All the commands are packaged as "yarn validate" already. So I just added this to the Readme.

@ghost ghost merged commit 241e6ac into stashapp:master Jul 31, 2022
@JackDawson94 JackDawson94 deleted the improve-readme branch July 31, 2022 21:28
InfiniteStash pushed a commit that referenced this pull request Nov 9, 2022
* Frontend README update to add PR checks list

* Fixed to encourage use of existing script

Co-authored-by: JackDawson94 <100418085+JackDawson94@users.noreply.github.co>
Co-authored-by: InfiniteTF <infinitekittens@protonmail.com>
InfiniteStash pushed a commit that referenced this pull request Nov 9, 2022
* Frontend README update to add PR checks list

* Fixed to encourage use of existing script

Co-authored-by: JackDawson94 <100418085+JackDawson94@users.noreply.github.co>
Co-authored-by: InfiniteTF <infinitekittens@protonmail.com>
Maista6969 pushed a commit to Maista6969/stash-box that referenced this pull request Jun 24, 2023
* Frontend README update to add PR checks list

* Fixed to encourage use of existing script

Co-authored-by: JackDawson94 <100418085+JackDawson94@users.noreply.github.co>
Co-authored-by: InfiniteTF <infinitekittens@protonmail.com>
feederbox826 pushed a commit to feederbox826/stash-box that referenced this pull request Nov 15, 2023
* Frontend README update to add PR checks list

* Fixed to encourage use of existing script

Co-authored-by: JackDawson94 <100418085+JackDawson94@users.noreply.github.co>
Co-authored-by: InfiniteTF <infinitekittens@protonmail.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants