require_activation now defaults to false, update and clarify README #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, require_activation was set to true by default, resulting in this warning message: RequireActivation is set to true, but the following required settings are missing: EmailFrom, EmailHost, HostURL Default behavior producing warning or error messages is confusing and should not happen. The only benefit of defaulting to true is if the error message helps point to the additinal settings. But a better way to inform the user is to clarify it in the README.
ghost
merged commit 
InfiniteStash
pushed a commit
that referenced
this pull request
Nov 9, 2022
…534) Previously, require_activation was set to true by default, resulting in this warning message: RequireActivation is set to true, but the following required settings are missing: EmailFrom, EmailHost, HostURL Default behavior producing warning or error messages is confusing and should not happen. The only benefit of defaulting to true is if the error message helps point to the additinal settings. But a better way to inform the user is to clarify it in the README.
InfiniteStash
pushed a commit
that referenced
this pull request
Nov 9, 2022
…534) Previously, require_activation was set to true by default, resulting in this warning message: RequireActivation is set to true, but the following required settings are missing: EmailFrom, EmailHost, HostURL Default behavior producing warning or error messages is confusing and should not happen. The only benefit of defaulting to true is if the error message helps point to the additinal settings. But a better way to inform the user is to clarify it in the README.
Maista6969
pushed a commit
to Maista6969/stash-box
that referenced
this pull request
Jun 24, 2023
…tashapp#534) Previously, require_activation was set to true by default, resulting in this warning message: RequireActivation is set to true, but the following required settings are missing: EmailFrom, EmailHost, HostURL Default behavior producing warning or error messages is confusing and should not happen. The only benefit of defaulting to true is if the error message helps point to the additinal settings. But a better way to inform the user is to clarify it in the README.
feederbox826
pushed a commit
to feederbox826/stash-box
that referenced
this pull request
Nov 15, 2023
…tashapp#534) Previously, require_activation was set to true by default, resulting in this warning message: RequireActivation is set to true, but the following required settings are missing: EmailFrom, EmailHost, HostURL Default behavior producing warning or error messages is confusing and should not happen. The only benefit of defaulting to true is if the error message helps point to the additinal settings. But a better way to inform the user is to clarify it in the README.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
require_activationwas set totrueby default, resulting in this warning message:Default behavior producing warning or error messages is confusing and should not happen. The only benefit of defaulting to true is if the error message helps point to the additinal settings. But a better way to inform the user is to clarify it in the README.