Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] Incorrect load of images on iOS devices #1430

Closed
SuperEllipsis opened this issue May 25, 2021 · 1 comment · Fixed by #1562
Closed

[Bug Report] Incorrect load of images on iOS devices #1430

SuperEllipsis opened this issue May 25, 2021 · 1 comment · Fixed by #1562
Labels
help wanted Extra attention is needed
Milestone

Comments

@SuperEllipsis
Copy link

SuperEllipsis commented May 25, 2021

Describe the bug
Images in the gallery view and images view load incorrectly most (Almost all) of the time, when using the wall display type. This problem has only occured on iOS devices (Both iOS, and iPadOS).

To Reproduce
Steps to reproduce the behavior:

  1. Go to the gallery tab
  2. Open some gallery
  3. Set display mode to 'Wall'
  4. Open an image
  5. If it loads correctly, change the device's orientation

Expected behavior
I expect the images to load in the correct size respective to the screen size of the device the image is being displayed on.

Screenshots
It sometimes works (image 1):
Stash

However change the screen orientation, and it disappears (image 2):
Stash 2

Change the orientation back, and it may return in a far smaller size (image 3):
Stash 3

On the smaller screen of the iPhone it usually does not show up at all (image 4):
Stash 4

Stash Version: v0.7.0 and v0.7.0-30-gd6ada236

Smartphone:

  • Device: iPhone 12
  • OS: iOS 14.5
  • Browser: safari

Tablet:

  • Device: iPad Pro 11-inch (1st gen)
  • OS: iPadOS 14.4
  • Browser: safari

Additional context
It seems typical for the images to not even render on iPhone, while it sometimes works on iPad until the screen orientation is changed. Once the orientation has been changed it usually makes all images in that gallery fail to render properly. It can be reset by closing the browser and opening it again. The state also does not seem to stick between galleries, one can open another gallery and the images in this gallery might work fine until the orientation is changed.

@SuperEllipsis SuperEllipsis added the help wanted Extra attention is needed label May 25, 2021
@thatbrick
Copy link
Contributor

Not sure what's causing the issue, but by playing around with the styling, I was able to load the image by commenting out the height parameter entirely for ".Lightbox-carousel-image" class.

thatbrick added a commit to thatbrick/stash that referenced this issue Jul 8, 2021
Resolves stashapp#1430 

* Removing the height parameter seems to resolve the issue without noticeable differences in functionality
@WithoutPants WithoutPants added this to the Version 0.9.0 milestone Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants