[Bug Report] macOS constant CPU use

[MC1R-13]

macOS constant CPU use

Sometime after v0.13.0-5-g9e3d56b2 from March 16, stash constantly uses a lot more resources than usual.
There was nothing in the log, but when I opened the console, it generated close 500,000 of these in just over a minute:

34074	error		00:37:02.936631-0500	stash-macos-intel	nextEventMatchingMask should only be called from the Main Thread!

34074	error		00:37:02.936919-0500	stash-macos-intel	(
	0   CoreFoundation                   	0x00007fff2074b29b __exceptionPreprocess + 242
	1   libobjc.A.dylib                 	0x00007fff20484d92 objc_exception_throw + 48
	2   AppKit                        	0x00007fff22ed7116 -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 4389
	3   AppKit                         	0x00007fff22ec8869 -[NSApplication run] + 586
	4   stash-macos-intel                	0x0000000004de4af5 nativeLoop + 53
	5   stash-macos-intel                	0x0000000004de3e3a _cgo_638c47e0eddf_Cfunc_nativeLoop + 26
	6   stash-macos-intel                	0x0000000004069d10 runtime.asmcgocall.abi0 + 112
)

I'm hoping someone knows what this means because I do not.

Stash Version: (from Settings -> About):
Anything after: v0.13.0-5-g9e3d56b2

Desktop (please complete the following information):

• OS: Mac OS Big Sur 11.6.5 (Intel)
• Browser: Safari
• Version: 15.4

[WithoutPants]

Relevant links:

• https://stackoverflow.com/questions/25361831/benefits-of-runtime-lockosthread-in-golang
• https://zchee.github.io/golang-wiki/LockOSThread/
• nextEventMatchingMask should only be called from the Main Thread! (MacOS) hybridgroup/gocv#31

I don't know what nativeLoop is or why it's causing this. Would be good to get a verification from another macOS user.

[bnkai]

Nativeloop seems to be used from the systray code getlantern/systray#34 , not sure what can be done though.

[WithoutPants]

We have a forked version of systray maintained by @kermieisinthehouse. Calling LockOSThread might help perhaps?

[bnkai]

From a quick look it seems that the run function from systray is using a nativeloop. Maybe add an init with the lock to the package and then check if the run function stays on the main thread as suggested from https://zchee.github.io/golang-wiki/LockOSThread/

[bnkai]

Scratch that. The library already does the init with lockosthread

[kermieisinthehouse]

The project refactor might've pushed the systray off the main thread. I'll investigate if that's the cause

[newadventure079]

FWIW, I'm on Monterey with an m1 chip and I dont see these issues

[MC1R-13]

That's not surprising, since you're using version 12, and this didn't start until after 13.

[newadventure079]

I tested it on version .13 also

[WithoutPants]

@MC1R-13 can you please test PR #2475 to see if it addresses the issue for you?

[MC1R-13]

All right, and as soon as I figure out how to build it, I will.

[WithoutPants]

See binaries here: https://github.com/stashapp/stash/actions/runs/2093097337

[MC1R-13]

Oh, nice!
Yes, it's back to using 0.0% cpu.
Thank you.