Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] lightbox: Play button not working, value changing, and input focus issue #2451

Closed
QxxxGit opened this issue Mar 30, 2022 · 0 comments · Fixed by #2457
Closed
Labels
bug Something isn't working

Comments

@QxxxGit
Copy link

QxxxGit commented Mar 30, 2022

Using commit f3355f3

Issues

  • Lightbox's play button stopped working.

  • Changing the delay value in the lightbox options seems to multiply it by 1000 as if converting from seconds to milliseconds, even though the input asks for seconds.

  • By default, my Settings -> Interface -> Slideshow Delay value was set to 5000. By changing it to 5, the play button started working normally again.

  • When attempting to type double digits in the lightbox delay setting, the focus to the input is lost. So if I attempt to type 10, it stops at 1 and I have to reclick the input to add the 0

Steps

Weird seconds to milliseconds conversion issue in lightbox options:

  • Go to any list of images, use grid or wall view
  • Open up the lightbox
  • Click the gear
  • Change the value to a single digit number like 3. Hit play, nothing happens.
  • Close and reopen the light box
  • Click the gear
  • The value will now say 3000.

Thoughts

WP thinks the interface setting used to be in milliseconds. If there was a change to this, users may need their values updated behind the scenes to account for this. Otherwise their lightbox will be 5000 seconds. May need more investigation to see if this is true.

I also think the Settings -> Interface -> Slideshow Delay option should specify seconds or milliseconds in the dialog window for clarity to the end user.

@QxxxGit QxxxGit added the help wanted Extra attention is needed label Mar 30, 2022
@WithoutPants WithoutPants added this to the Version 0.14.0 milestone Mar 30, 2022
@WithoutPants WithoutPants added bug Something isn't working and removed help wanted Extra attention is needed labels Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants