Improve performance of gallery and image queries #2422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Galleries load faster on my database, from many seconds to under one second. Accessing the images view still takes ~15 seconds, regardless of sort |
kermieisinthehouse
approved these changes
Mar 24, 2022
bnkai
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2347
Reverts to use
FindByGalleryIDfor gallery image queries. Changed the query string to use an inner join, which is faster.Optimised the
getMultiCriterionClauseto utilise the join table is present.This addresses a performance regression introduced in the dev branch, and a latent performance issue for
findImages.On my contrived database with 4m images, it reduced the load time for
findImagesfrom 5.5s to 123ms.findGallerieswasn't returning at all.