Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lightbox issues #2457

Merged
merged 8 commits into from
Apr 3, 2022
Merged

Conversation

WithoutPants
Copy link
Collaborator

@WithoutPants WithoutPants commented Mar 31, 2022

Fixes #2451
Fixes #2469

  • this makes the delay setting in interface settings in seconds rather than milliseconds, to be consistent with the lightbox interface. I will add a note in the changelog notifying users of this, since no conversion of existing values will be done.
  • fixed slideshow delay setting to use the correct interval value
  • fixed issue that caused focus to be lost on the delay input field when typing

Also changes the localforage hook to store objects directly instead of converting to and from json strings.

@WithoutPants WithoutPants added the bug Something isn't working label Mar 31, 2022
@WithoutPants WithoutPants added this to the Version 0.14.0 milestone Mar 31, 2022
@bnkai
Copy link
Collaborator

bnkai commented Apr 2, 2022

The duration setting in the interface settings page and the actual lightbox has an issue now.
Setting a 3 secs duration in the interface settings results in 0.003 in the lightbox
interface-settings

lightbox-settings

@WithoutPants WithoutPants merged commit 92320b3 into stashapp:develop Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants