Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Images new fields : URL & Date #3015

Merged
merged 23 commits into from Dec 20, 2022
Merged

[Feature] Images new fields : URL & Date #3015

merged 23 commits into from Dec 20, 2022

Conversation

ghost
Copy link

@ghost ghost commented Oct 18, 2022

Scope

As part of my work toward Image scraping, i first added URL and Date as fields for Images.
image
image
image
Also include the fix to 👍
image

@cj12312021
Copy link
Collaborator

Looking at the images you posted, the URL field should be displayed in the File Info tab using the Downloaded From: message to be consistent with URL fields elsewhere.

@ghost
Copy link
Author

ghost commented Oct 18, 2022

Arf i missed that part. Ok i'll make the changes

@ghost
Copy link
Author

ghost commented Oct 18, 2022

Turns out i cant. The way the props is made differently on images, that requires changing the props type aand i dont manage to do it. Would you lend me an hand please :3

@cj12312021
Copy link
Collaborator

cj12312021 commented Oct 18, 2022

I wouldn't be able to hop on your branch until the weekend at the soonest. With the changes, you've made so far though it seems like props.image.url should work from ImageFileInfoPanel.tsx.

@ghost
Copy link
Author

ghost commented Oct 18, 2022

So i spent over an hour understanding the code but i managed to do it :)
image

@DogmaDragon
Copy link
Collaborator

So i spent over an hour understanding the code but i managed to do it :) image

For consistency could you move the Downloaded From: to the bottom? That's how Scenes list it.

@ghost
Copy link
Author

ghost commented Oct 18, 2022

Done

Merge to master for release
@WithoutPants WithoutPants added this to the Version 0.18.0 milestone Oct 19, 2022
@ghost ghost requested a review from WithoutPants December 10, 2022 16:21
@ghost
Copy link
Author

ghost commented Dec 11, 2022

I've fixed the issues you raised, rebased onto master and changed the migration version for the DB. I think its ready for merging.

@WithoutPants WithoutPants added the feature Pull requests that add a new feature label Dec 20, 2022
@WithoutPants WithoutPants merged commit 0b4b100 into stashapp:develop Dec 20, 2022
yoshnopa added a commit to yoshnopa/stash that referenced this pull request Dec 21, 2022
yoshnopa added a commit to yoshnopa/stash that referenced this pull request Dec 21, 2022
@ghost ghost deleted the ImageNewFields branch January 3, 2023 15:54
@WithoutPants WithoutPants linked an issue Mar 7, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Pull requests that add a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add 'date' field to images and display performer age
5 participants