Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle large and all entity queries #3544

Merged
merged 4 commits into from
Mar 15, 2023

Conversation

WithoutPants
Copy link
Collaborator

Resolves #3199

Batches FindMany queries per 1000 ids. Also removes the upper limit on the page size in the backend interface and in the UI. If we accept -1 value page size, then we shouldn't be limiting the upper limit.

@WithoutPants WithoutPants added the bug Something isn't working label Mar 15, 2023
@WithoutPants WithoutPants added this to the Version 0.20.0 milestone Mar 15, 2023
@stg-annon
Copy link
Collaborator

tested with findScenes query on live db with 74K scenes appears to work as intended

per_page = -1

image

per_page = 33000

image

@WithoutPants WithoutPants merged commit 58852f8 into stashapp:develop Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] GraphQL error when selecting -1 page limit with large result set
2 participants