Refactor and fix stash-box submit dialog #4355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the
SubmitDraftdialog to simplify it a bit and to fix #4354.The dialog's state will now be reset every time it is opened, which also allows to submit the same scene to multiple stashboxes (or to the same stash-box multiple times, if you wanted to).
Besides that bugfix, I've also moved the "Submit" button and the "Already exists in stash-box" message to the dialog's footer. This means that the loading spinner can now be inside the "Submit" button - previously it would show inside the "Cancel" button, which is a bit odd.
Fixes #4354