From 26eb61092be087e082e79cc4849b8db8353be6b6 Mon Sep 17 00:00:00 2001 From: Danijel K Date: Wed, 21 Oct 2020 20:22:41 +0200 Subject: [PATCH 1/2] Make shuffle work for collections This fixes the shuffle modifier for collections --- src/Modifiers/CoreModifiers.php | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/Modifiers/CoreModifiers.php b/src/Modifiers/CoreModifiers.php index 15c2623de8..86c4fcb6ce 100644 --- a/src/Modifiers/CoreModifiers.php +++ b/src/Modifiers/CoreModifiers.php @@ -1822,6 +1822,10 @@ public function shuffle($value) if (is_array($value)) { return collect($value)->shuffle()->all(); } + + if ($value instanceof Collection) { + return $value->shuffle(); + } return Stringy::shuffle($value); } From 2780985f004edfa69cea054a18c060ee7c1be478 Mon Sep 17 00:00:00 2001 From: Danijel K Date: Thu, 22 Oct 2020 08:33:56 +0200 Subject: [PATCH 2/2] Update CoreModifiers.php --- src/Modifiers/CoreModifiers.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Modifiers/CoreModifiers.php b/src/Modifiers/CoreModifiers.php index 86c4fcb6ce..24342de7cd 100644 --- a/src/Modifiers/CoreModifiers.php +++ b/src/Modifiers/CoreModifiers.php @@ -1822,7 +1822,7 @@ public function shuffle($value) if (is_array($value)) { return collect($value)->shuffle()->all(); } - + if ($value instanceof Collection) { return $value->shuffle(); }