Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUNME NOTEBOOKS shows wrong markdown files #704

Open
rubensa opened this issue Nov 27, 2024 · 4 comments
Open

RUNME NOTEBOOKS shows wrong markdown files #704

rubensa opened this issue Nov 27, 2024 · 4 comments
Assignees
Labels
documentation Improvements or additions to documentation question Further information is requested

Comments

@rubensa
Copy link

rubensa commented Nov 27, 2024

It should respect the workbench.editorAssociations setting to filter out those extensions not associated with runme.

I just want the default editor to be used for *.md files but runme editor por *.runme files so I set:

        "workbench.editorAssociations": {
          // Use default editor for markdown files (do not use runme editor)
          "*.md": "default",
          // Use runme editor for extended runable markdown files
          "*.runme": "runme"
        },

The files are opened with the right editor but the RUNME NOTEBOOKS shows .md (but it should show .runme files instead).

@rubensa rubensa changed the title RUNME NOTEBOOKS shows all markdown files RUNME NOTEBOOKS shows wrong markdown files Nov 27, 2024
@sourishkrout
Copy link
Member

sourishkrout commented Nov 27, 2024

Hi @rubensa. Thanks for reporting the issue. While default works locally for me. I believe the out-of-the-box settings is below, not default:

  "workbench.editorAssociations": {
    "*.md": "vscode.markdown.preview.editor"
  },

Please let me know if that works. Btw, it will set the right value if you go through right click on the file and then Open with..., then select Configure default....

@sourishkrout sourishkrout added documentation Improvements or additions to documentation question Further information is requested labels Nov 27, 2024
@rubensa
Copy link
Author

rubensa commented Nov 28, 2024

First, sorry, as this issue should have been opened at https://github.com/stateful/vscode-runme, not here, as it is an issue in a VSCode view.

As for the content of the issue, I must say that the VSCode default if for *.md files to be opened with the Builtin Text Editor (and you can "reset" that functionality, after installing Runme extension, setting the configuration I provided).

That said, the issue is that the RUNME NOTEBOOKS view shows, grouped by folder, all *.md files and it does not include in the list the *.runme files that I have associated with the runme extension editor.

NOTE: When I say RUNME NOTEBOOKS view I'm talking about the view labeled as "All Markdowns available to open as Notebooks" in the image from Notebook UX in VSCode doc.

@sourishkrout
Copy link
Member

sourishkrout commented Dec 2, 2024

Thanks for the clarification @rubensa. Fine to file the issue here on runme versus vscode-runme.

We are working on replacing the Runme Notebooks panel with a newer implementation. The beta will be available shortly. I will leave this issue open to see what we can do about filtering out specific extensions.

@sourishkrout sourishkrout self-assigned this Dec 2, 2024
@rubensa
Copy link
Author

rubensa commented Dec 3, 2024

Thank you for the info @sourishkrout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants