Refactor project package to allow linkage #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pastuxso
reviewed
Sep 25, 2023
internal/cmd/tui.go
Outdated
| @@ -37,7 +37,8 @@ func tuiCmd() *cobra.Command { | |||
| return err | |||
| } | |||
|
|
|||
| blocks, err := loadTasks(proj, cmd.OutOrStdout(), cmd.InOrStdin(), false) | |||
| loader := getLoader(cmd) | |||
There was a problem hiding this comment.
@sourishkrout It would be fine if project.NewLoader would have a return with error as well.
There was a problem hiding this comment.
@pastuxso can you push a commit on top with the changes you have in mind?
- handle potential error. - renames function getLoader to newProjectLoader
pastuxso
force-pushed
the
refactor-project-layout
branch
from
a18d448 to
047db90
Compare
|
Thanks @pastuxso! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No change to functionality whatsover.