Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runme v3 release prep #496

Merged
merged 5 commits into from
Feb 12, 2024
Merged

Runme v3 release prep #496

merged 5 commits into from
Feb 12, 2024

Conversation

sourishkrout
Copy link
Member

@sourishkrout sourishkrout commented Feb 12, 2024

Final changes to get v3.0 out the door:

  1. Remove branch cmd (however, keep suggest in please for now which works the same way).
  2. Login/logout are hidden since they are no longer required (branch cmd, removed).
  3. Base Version is no longer defined as v<major>.<minor>, it's v<major> now.
  4. Unrelated item, include private metadata into cell whether or not a name was generated for future extension feature.

That's it.

@sourishkrout sourishkrout marked this pull request as draft February 12, 2024 21:49
Use: "run-locally [command1 command2 ...]",
Short: "Run one or more commands.",
Use: "run-locally [command1 command2 ...]",
Hidden: true,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adambabik FYI, I'm hiding this for now to avoid confusion; this is intentional.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, totally. It should be hidden from the beginning...

@sourishkrout sourishkrout marked this pull request as ready for review February 12, 2024 22:01
@@ -1,3 +1,5 @@
//go:test !darwin
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go tired of running into third-party rate-limiting. It's totally fine to not run this test locally as long as it runs in C/I.

Copy link
Collaborator

@pastuxso pastuxso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

sonarcloud bot commented Feb 12, 2024

@sourishkrout sourishkrout merged commit 2079fb6 into main Feb 12, 2024
6 checks passed
@sourishkrout sourishkrout deleted the runme-v3 branch February 12, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants