Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider the following Markdown file:
When executing it with
runme run
, the exit code for both should not be zero. This PR makes sure this is the actual behaviour.The problem was in how we collect the environment variable. The solution was to switch to a clean up function instead of doing it inline, which could overwrite the original exit status.
Another problem, which is not covered in this PR, is to surface the actual shell exit code rather than any non-zero value convert to
1
. This is due to an explicit conversion in:runme/main.go
Lines 22 to 25 in 064e483