Upgrade to go 1.22 #511
Merged
Upgrade to go 1.22 #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
General maintenance review, please, @pastuxso. |
|
pastuxso
reviewed
Feb 21, 2024
| } | ||
| } | ||
| } else { | ||
| if typ := reflect.TypeOf(uErrs); typ.Kind() != reflect.Slice { |
There was a problem hiding this comment.
@sourishkrout, I'm wondering if this refactoring is part of the upgrade, and can be addressed in a separate PR?
Is it part of the go lint/format?
There was a problem hiding this comment.
Yes, lint/format after upgrade requires to turn if/else into early returns/breaks wherever possible. I think those changes are safe since we have broad test coverage for this code.
| firstError = errors.Wrap(err, "failed to parse frontmatter content") | ||
| } | ||
| } else { | ||
| if err == nil { |
|
LGTM.
Build and tests are working fine, VS Code extension too. 👌 |
pastuxso
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumping dependencies at the same time.