Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate project and runtime options in runme.yaml #584

Merged
merged 1 commit into from
May 23, 2024
Merged

Separate project and runtime options in runme.yaml #584

merged 1 commit into from
May 23, 2024

Conversation

adambabik
Copy link
Collaborator

Replaces #553

@adambabik adambabik force-pushed the adamb/re-apply-config-plus branch from 7d44cbc to 4961a6b Compare May 22, 2024 21:54
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 22, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
72.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@adambabik adambabik changed the base branch from main to adamb/runme-yaml-remove-kernel May 23, 2024 18:13
@adambabik adambabik marked this pull request as ready for review May 23, 2024 18:13
@adambabik adambabik requested a review from sourishkrout May 23, 2024 18:13
sourishkrout
sourishkrout approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@sourishkrout sourishkrout left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM. It does not include the notion of kernel which wasn't was runtime is now but it's much closer. So let's roll with it for the time being.

@sourishkrout sourishkrout merged commit 6af9581 into adamb/runme-yaml-remove-kernel May 23, 2024
6 checks passed
@sourishkrout sourishkrout deleted the adamb/re-apply-config-plus branch May 23, 2024 19:39
@sourishkrout sourishkrout mentioned this pull request May 23, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourishkrout sourishkrout sourishkrout approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adambabik @sourishkrout