Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a Docker image capable of running tests #608

Merged
merged 14 commits into from
Jun 11, 2024
Merged

Add a Docker image capable of running tests #608

merged 14 commits into from
Jun 11, 2024

Conversation

adambabik
Copy link
Collaborator

@adambabik adambabik commented Jun 5, 2024 •
edited
Loading

This change adds a new GHA workflow that runs tests in a Docker container. It appears as a new check but it's not required, for now.

Other changes:

  • GoReleaser update
  • Docker image release in GoReleaser config
  • Moving of tests setup from Makefile entirely to Go

Closes #605

@adambabik adambabik force-pushed the adamb/runme-test-env-in-docker branch from bdf453f to 688b8c6 Compare June 6, 2024 22:12
@adambabik adambabik marked this pull request as ready for review June 10, 2024 19:39
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 10, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
7 Security Hotspots

See analysis details on SonarCloud

sourishkrout
sourishkrout approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@sourishkrout sourishkrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM - I'm giving a release a try

@sourishkrout sourishkrout merged commit 033006a into main Jun 11, 2024
6 of 7 checks passed
@sourishkrout sourishkrout deleted the adamb/runme-test-env-in-docker branch June 11, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourishkrout sourishkrout sourishkrout approved these changes

@pastuxso pastuxso Awaiting requested review from pastuxso

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a Docker image capable of running unit and integration tests
2 participants
@adambabik @sourishkrout