Rendering New Notebooks Panel using VS Code Task Provider #1784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pastuxso
force-pushed
the
cris/runme-notebooks-panel-improvements
branch
from
141ba89 to
a74c7b4
Compare
pastuxso
force-pushed
the
cris/runme-notebooks-panel-improvements
branch
from
a74c7b4 to
d63f82d
Compare
pastuxso
changed the title
pastuxso
changed the title
There was a problem hiding this comment.
Is it possible to not uncollapse the whole tree when switching between named / unnamed @pastuxso?
Screen.Recording.2024-11-20.at.10.39.47.AM.mov
- Introduced caching for notebooks and their cells to optimize tree view rendering. - Added a parent property to RunmeFile to properly associate child items with their parent notebooks. - Updated getChildren method to use cached data and return child items based on their parent. - Removed unnecessary sauceCount logic, simplifying the tree re-rendering workaround. - Added logic to store and preserve the collapsibleState when including named or unnamed cells
sourishkrout
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring of New Notebooks Panel in order to avoid duplication and to have a unique source of truth for tasks.