Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fully async to never block execution #1799

Merged
merged 3 commits into from
Nov 18, 2024
Merged

Fully async to never block execution #1799

merged 3 commits into from
Nov 18, 2024

Conversation

sourishkrout
Copy link
Member

@sourishkrout sourishkrout commented Nov 18, 2024 •
edited
Loading

  1. Break out code that only runs for logged in users
  2. Enqueue cell runs (sync), immediately return to unblock execution
  3. Report cell runs only for logged in users (async)

pastuxso
pastuxso approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@pastuxso pastuxso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sourishkrout sourishkrout merged commit 4ef50a2 into main Nov 18, 2024
1 check passed
@sourishkrout sourishkrout deleted the seb/async-cell-runs branch November 18, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pastuxso pastuxso pastuxso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sourishkrout @pastuxso