-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor StatefulAuthProvider for static initialization and improved session management #1822
Conversation
6956ac7
to
a22b762
Compare
According to the docs, the value (webview) is not being emmited, it’s because the subscription should be settled before the call of the .next() function I need help on it.
Hi @sourishkrout, I had to rollback the reactive approach in cloud.ts (d2040b1). Unfortunately, the subscription isn't being triggered, so the panel fails to refresh its content as intended. I've recorded a video demonstrating the steps to test the desired functionality. Your expertise would be greatly appreciated to resolve this issue. Let me know if you need any further details! Thanks! 🙌 login-logout.mp4 |
@pastuxso When I open the Runme side panel, I'll immediately get prompted to log in. That's not right. It should display the "Sign in or create account" button first. |
Just to confirm, is it happening for Stateful or Runme ext? |
I've only tested Runme so far. |
@sourishkrout, I’ve tried to replicate it for Runme, but I couldn’t. The only way to replicate is within Stateful Extension. I wonder if a specific setting might be causing this issue. Would you mind sending me a screenshot of your panel so I can take a closer look? |
I believe this below is the issue. It forces the creation of a session inside the call stack without 'true' here. That being said, I wonder if the client flag should be an object and explicit. Optional arguments are easy to overlook.
|
- Refactored `ensureSession` to operate as an instance method instead of static. - Removes unnecessary code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ LGTM
This refactor centralizes session management, reduces duplication, and improves maintainability across the extension.