Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] SSZ unsigned integer + test suite genericity #284

Merged
merged 8 commits into from
Jun 17, 2019
Merged

Conversation

mratsim
Copy link
Contributor

@mratsim mratsim commented Jun 13, 2019

Adds the unsigned int official fixtures of SSZ to the test suite.
This also revamp the test suite to be generic over presets and the test cases following status-im/nim-serialization#4 and status-im/nim-serialization#5 (upstream bug nim-lang/Nim#11225)

In details this PR does the following

  • Genericity

    • Now a single parseTests that accepts test types is defined
    • Test types have been moved to their test files instead of fixture_utils.nim
  • SSZ uint tests added except

@mratsim mratsim requested a review from zah June 13, 2019 08:47
@mratsim
Copy link
Contributor Author

mratsim commented Jun 14, 2019

When I compile the file test_fixture_ssz_uint.nim file alone and run it, test is OK, when run in the full test suite the unittest expect template throws:

Expect Failed, unexpected exception was thrown.

Edit: it was an AssertionError that was thrown in stint, raised status-im/nim-stint#79 to use a single RangeError in the future

@mratsim
Copy link
Contributor Author

mratsim commented Jun 14, 2019

Not sure about the windows 64-bit only "Access is denied" error.

@tersec tersec merged commit 0926ebf into master Jun 17, 2019
@delete-merged-branch delete-merged-branch bot deleted the ssz-uint-tests branch June 17, 2019 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants