Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore_: bump status-go with message hash query for outgoing messages #20387

Closed
wants to merge 3 commits into from

Conversation

kaichaosun
Copy link
Contributor

@kaichaosun kaichaosun commented Jun 7, 2024

Summary

For status-go: status-im/status-go#5217

For outgoing messages, only mark it as it sent after successfully found in store node, the messages that are sent 5s ago and not found in store node will be marked as expired and resend.
For DM, since ack marks the outgoing message as delivered, the delivered messages will skip the above query, but will still update the sent status in raw_message table to 1.

For UX changes, after input a message and click return, the message will be not marked as sent (1 tick) in status-mobile immediately, instead it takes 5s to 10s to do so for un-acked messages.

Please help verify the changes @churik
cc @cammellos

Important changes:

Find outgoing messages which were sent 5s ago, query the store node with the hashes of the messages
message found will trigger EventEnvelopeSent, messages missed will trigger EventEnvelopeExpired

Review notes

Testing notes

Platforms

  • Android
  • iOS
  • macOS
  • Linux
  • Windows

Areas that maybe impacted

Functional
  • 1-1 chats
  • public chats
  • group chats
  • wallet / transactions
  • dapps / app browsing
  • account recovery
  • new account
  • user profile updates
  • networks
  • mailservers
  • fleet
  • bootnodes
Non-functional
  • battery performance
  • CPU performance / speed of the app
  • network consumption

Steps to test

  • Open Status
  • ...
  • Step 3, etc.

Before and after screenshots comparison

Figma (if available) iOS (if available) Android (if available)
Please embed Image/Video here of the before and after. Please embed Image/Video here of the before and after. Please embed Image/Video here of the before and after.

status: ready

@kaichaosun kaichaosun marked this pull request as draft June 7, 2024 03:14
@status-im-auto
Copy link
Member

status-im-auto commented Jun 7, 2024

Jenkins Builds

Click to see older builds (4)
Commit #️⃣ Finished (UTC) Duration Platform Result
fde7f3d #1 2024-06-07 03:20:08 ~5 min tests 📄log
✔️ fde7f3d #1 2024-06-07 03:24:31 ~9 min android-e2e 🤖apk 📲
✔️ fde7f3d #1 2024-06-07 03:25:31 ~10 min android 🤖apk 📲
✔️ fde7f3d #1 2024-06-07 03:29:05 ~14 min ios 📱ipa 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 0bcef84 #2 2024-06-11 02:27:26 ~5 min tests 📄log
✔️ 0bcef84 #2 2024-06-11 02:31:04 ~9 min android-e2e 🤖apk 📲
✔️ 0bcef84 #2 2024-06-11 02:32:00 ~10 min android 🤖apk 📲
✔️ 0bcef84 #2 2024-06-11 02:35:35 ~14 min ios 📱ipa 📲
✔️ b532b8e #3 2024-06-11 10:41:04 ~10 min tests 📄log
✔️ b532b8e #3 2024-06-11 10:43:57 ~13 min android-e2e 🤖apk 📲
✔️ b532b8e #3 2024-06-11 10:45:00 ~14 min android 🤖apk 📲
✔️ b532b8e #3 2024-06-11 10:51:11 ~20 min ios 📱ipa 📲

@flexsurfer flexsurfer added status-go waku All issues relating to the Status Waku integration. labels Jun 10, 2024
@kaichaosun kaichaosun closed this Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status-go waku All issues relating to the Status Waku integration.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants