From 421b0add6773c3c6335069656c70531373ccbec8 Mon Sep 17 00:00:00 2001 From: steelbrain <de.steelbrain@gmail.com> Date: Thu, 24 Mar 2016 11:29:11 -0700 Subject: [PATCH 1/3] :art: Cleanup API in README --- README.md | 22 ++++++++++------------ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/README.md b/README.md index 2f88687..31da629 100644 --- a/README.md +++ b/README.md @@ -10,18 +10,16 @@ For full documentation of `exec` and `execNode` API, please refer to [`sb-exec R ```js export const FindCache: Map -class Helpers{ - static exec(command: String, args: Array<string> = [], options: Object) - static execNode(filePath: String, args: Array<string> = [], options: Object) - static parse(data: String, regex: String, options: Object = {baseReduction: 1, flags: ""}) - static rangeFromLineNumber(textEditor: TextEditor, lineNumber: Number, colStart: Number = <firstColumn>):Array - static find(directory:String, names: String | Array<string>): ?String - static findCached(directory:String, names: String | Array<string>): ?String - static findAsync(directory: String, names: String | Array<string>): Promise<?String> - static findCachedAsync(directory: String, names: String | Array<string>): Promise<?String> - static tempFile<T>(fileName:String, fileContents:String, Callback:Function<T>):Promise<T> - static tempFiles<T>(filesNames:Array<{name: String, contents: String}>, callback:Function<T>):Promise<T> -} +export function exec(command: String, args: Array<string> = [], options: Object) +export function execNode(filePath: String, args: Array<string> = [], options: Object) +export function parse(data: String, regex: String, options: Object = {baseReduction: 1, flags: ""}) +export function rangeFromLineNumber(textEditor: TextEditor, lineNumber: Number, colStart: Number = <firstColumn>):Array +export function find(directory:String, names: String | Array<string>): ?String +export function findCached(directory:String, names: String | Array<string>): ?String +export function findAsync(directory: String, names: String | Array<string>): Promise<?String> +export function findCachedAsync(directory: String, names: String | Array<string>): Promise<?String> +export function tempFile<T>(fileName:String, fileContents:String, Callback:Function<T>):Promise<T> +export function tempFiles<T>(filesNames:Array<{name: String, contents: String}>, callback:Function<T>):Promise<T> ``` #### License From 0027cb567342ecdd5082c898ea902fd921caa6c7 Mon Sep 17 00:00:00 2001 From: steelbrain <de.steelbrain@gmail.com> Date: Thu, 24 Mar 2016 12:01:19 -0700 Subject: [PATCH 2/3] :art: Address reviewer's comments --- README.md | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/README.md b/README.md index 31da629..e7731ef 100644 --- a/README.md +++ b/README.md @@ -10,16 +10,16 @@ For full documentation of `exec` and `execNode` API, please refer to [`sb-exec R ```js export const FindCache: Map -export function exec(command: String, args: Array<string> = [], options: Object) -export function execNode(filePath: String, args: Array<string> = [], options: Object) -export function parse(data: String, regex: String, options: Object = {baseReduction: 1, flags: ""}) -export function rangeFromLineNumber(textEditor: TextEditor, lineNumber: Number, colStart: Number = <firstColumn>):Array -export function find(directory:String, names: String | Array<string>): ?String -export function findCached(directory:String, names: String | Array<string>): ?String +export function exec(command: String, args: Array<string> = [], options: Object): Promise +export function execNode(filePath: String, args: Array<string> = [], options: Object): Promise +export function parse(data: String, regex: String, options: Object = {flags: 'g'}): Array<Linter$Message> +export function rangeFromLineNumber(textEditor: TextEditor, lineNumber: Number = 0, colStart: Number = <firstTextColumn>): Array +export function find(directory: String, names: String | Array<string>): ?String +export function findCached(directory: String, names: String | Array<string>): ?String export function findAsync(directory: String, names: String | Array<string>): Promise<?String> export function findCachedAsync(directory: String, names: String | Array<string>): Promise<?String> -export function tempFile<T>(fileName:String, fileContents:String, Callback:Function<T>):Promise<T> -export function tempFiles<T>(filesNames:Array<{name: String, contents: String}>, callback:Function<T>):Promise<T> +export function tempFile<T>(fileName: String, fileContents: String, callback: Function<T>): Promise<T> +export function tempFiles<T>(filesNames: Array<{ name: String, contents: String }>, callback: Function<T>): Promise<T> ``` #### License From 457af9c4fb76cbbcc0aa737922b890e7711a05ff Mon Sep 17 00:00:00 2001 From: steelbrain <de.steelbrain@gmail.com> Date: Thu, 24 Mar 2016 12:38:00 -0700 Subject: [PATCH 3/3] :arrow_up: Pin a beta version of babel-eslint to fix CI --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 033ee47..fb3be1e 100644 --- a/package.json +++ b/package.json @@ -30,7 +30,7 @@ }, "devDependencies": { "eslint": "^2.2.0", - "babel-eslint": "^5.0.0", + "babel-eslint": "6.0.0-beta.6", "eslint-config-airbnb": "^6.0.2", "ucompiler": "^3.0.1", "ucompiler-plugin-babel": "^3.0.0",