From 5befd2b43d4156145beff97a6ccd6c2f73a3dd50 Mon Sep 17 00:00:00 2001
From: steelbrain <de.steelbrain@gmail.com>
Date: Tue, 16 Feb 2016 18:03:31 +0000
Subject: [PATCH] :art: Minor enhancements in installDependencies helper

---
 src/helpers.js | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/src/helpers.js b/src/helpers.js
index 0874bf7..e3c9ea8 100644
--- a/src/helpers.js
+++ b/src/helpers.js
@@ -13,10 +13,10 @@ export function spawnAPM(dependencies, progressCallback) {
       options: {},
       stdout: function(contents) {
         const matches = extractionRegex.exec(contents)
-        progressCallback()
         if (matches[2] === '✓' || matches[2] === 'done') {
-          // Succeeded
+          progressCallback(matches[1], true)
         } else {
+          progressCallback(matches[1], false)
           errors.push(matches[1])
         }
       },
@@ -37,19 +37,23 @@ export function spawnAPM(dependencies, progressCallback) {
 
 export async function installDependencies(name, packages) {
   const view = new View(name, packages)
+  const installedPackages = []
   try {
-    await spawnAPM(packages, function() {
+    await spawnAPM(packages, function(name, status) {
       view.advance()
+      if (status) {
+        installedPackages.push(name)
+      }
     })
     view.markFinished()
   } catch (error) {
     view.dismiss()
-    atom.notifications.addError(`Error installing ${this.name} dependencies`, {
+    atom.notifications.addError(`Error installing ${name} dependencies`, {
       detail: error.stack,
       dismissable: true
     })
   } finally {
-    await Promise.all(packages.map(name => atom.packages.activatePackage(name)))
+    await Promise.all(installedPackages.map(name => atom.packages.activatePackage(name)))
   }
 }