Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with sep6 deposit #713

Open
nikita-gorodeckij opened this issue Oct 21, 2023 · 0 comments
Open

Bug with sep6 deposit #713

nikita-gorodeckij opened this issue Oct 21, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@nikita-gorodeckij
Copy link
Contributor

Here you check if fee function has been changed:
https://github.com/stellar/django-polaris/blob/v2.3.9/polaris/sep6/deposit.py#L190

But if it was changed there is no any way to set fee

Withdrawals with sep6 have better solution:
https://github.com/stellar/django-polaris/blob/v2.3.9/polaris/sep6/withdraw.py#L339

I think you should make the same solution for deposits

@nikita-gorodeckij nikita-gorodeckij added the bug Something isn't working label Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant