Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit error log after X failed attempts to validate state #1822

Closed
bartekn opened this issue Oct 10, 2019 · 1 comment
Closed

Emit error log after X failed attempts to validate state #1822

bartekn opened this issue Oct 10, 2019 · 1 comment
Assignees
@tamirms
Labels
horizon ingest New ingestion system
Milestone
Horizon 0.24.0

Comments

@bartekn
Copy link
Contributor

bartekn commented Oct 10, 2019

Currently we emit error log every time there's a problem with state validation, however, sometimes temporary errors like network connection issues happen. Maybe we should keep track of invalid attempts and emit error after 2-3 failed attempts. First failed attempts should be warning or info level.
@bartekn bartekn added horizon ingest New ingestion system labels Oct 10, 2019
@tamirms tamirms self-assigned this Nov 12, 2019
@tamirms tamirms mentioned this issue Nov 13, 2019
Merged
7 tasks
@bartekn
Copy link
Contributor Author

bartekn commented Nov 18, 2019

Fixed in #1918.

@bartekn bartekn closed this as completed Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tamirms tamirms

Labels
horizon ingest New ingestion system
Projects
None yet
Milestone
Horizon 0.24.0
Development

No branches or pull requests
3 participants
@bartekn @tamirms @ire-and-curses