Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update verify-range docker image to use 1.0.0 as base #2389

Closed
abuiles opened this issue Mar 16, 2020 · 1 comment · Fixed by #2427
Closed

Update verify-range docker image to use 1.0.0 as base #2389

abuiles opened this issue Mar 16, 2020 · 1 comment · Fixed by #2427
Labels
feature request horizon

Comments

@abuiles
Copy link
Contributor

abuiles commented Mar 16, 2020

verify-range is currently using h_0.24.1_v2_meta as base - it works fine for most of the scenarios but then it fails with the same failures here #2133

Let's update verify-range to use 1.0.0 as base and apply #2375 to avoid false positives.
@abuiles
Copy link
Contributor Author

abuiles commented Mar 17, 2020

While doing this, let's add extra logging before running the diff, specifically, output the size of each size, this will help us with diff: memory exhausted problem.

@abuiles abuiles mentioned this issue Mar 30, 2020
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request horizon
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

services/horizon/docker: Update verify-range to use 1.0.0 as base. abuiles/go
1 participant
@abuiles