Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CAP 15 (fee bump) support in Go SDK #2468

Closed
6 tasks
ire-and-curses opened this issue Apr 7, 2020 · 2 comments
Closed
6 tasks

Implement CAP 15 (fee bump) support in Go SDK #2468

ire-and-curses opened this issue Apr 7, 2020 · 2 comments
Assignees
Labels
horizonclient tag for new horizon client located in clients/horizonclient txnbuild 2nd-generation transaction build library for Go SDK
Milestone

Comments

@ire-and-curses
Copy link
Member

ire-and-curses commented Apr 7, 2020

This work needs to be done in two parts.

  • In part 1, we release an SDK that sends protocol 12 transactions, and can read protocol 13 as far as possible.

  • In part 2, we release an SDK that reads and writes protocol 13 transactions.

  • Update SDK so that it is compatible with the new horizon transaction response structure

  • Update SDK to allow transaction lookup by either its hash or its inner hash (in the case the transaction is a fee bump)

  • Consider what other features could make look ups for fee bumps ergonomic

  • Update SDK to build transactions from XDR from both protocol 12 and protocol 13, as far as possible. This means shimming for part 1.

  • Update SDK with functionality to create and submit fee bump transactions. Note that fee bump transactions have a different fee rate calculation compared to normal transactions.

  • Consider SEP 10 implications of fee bump transactions. We probably want to add the restriction that a fee bump transaction cannot be a valid SEP 10 challenge transaction.

Parent issue: #2360

@ire-and-curses ire-and-curses added txnbuild 2nd-generation transaction build library for Go SDK horizonclient tag for new horizon client located in clients/horizonclient labels Apr 7, 2020
@ire-and-curses ire-and-curses added this to the Horizon 1.2.0 milestone Apr 7, 2020
@ire-and-curses
Copy link
Member Author

ire-and-curses commented Apr 7, 2020

@tamirms I made a first sketch summarising the work, please edit at will. Also, if it makes more sense to split this issue to address the two different client releases (before and after the vote), please do so.

@bartekn
Copy link
Contributor

bartekn commented May 12, 2020

Presumably fixed by #2495. Can you confirm? If not, please reopen.

@bartekn bartekn closed this as completed May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
horizonclient tag for new horizon client located in clients/horizonclient txnbuild 2nd-generation transaction build library for Go SDK
Projects
None yet
Development

No branches or pull requests

3 participants