Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove setting NETWORK_PASSPHRASE to default testnet value #817

Closed
bartekn opened this issue Jan 17, 2019 · 2 comments
Closed

Remove setting NETWORK_PASSPHRASE to default testnet value #817

bartekn opened this issue Jan 17, 2019 · 2 comments
Assignees
@ire-and-curses
Labels
help wanted horizon

Comments

@bartekn
Copy link
Contributor

bartekn commented Jan 17, 2019

No description provided.

@bartekn bartekn added this to the Horizon v0.16.0 milestone Jan 17, 2019
@bartekn bartekn mentioned this issue Jan 17, 2019
Merged
@tomquisel tomquisel modified the milestones: Horizon v0.16.0, Horizon patch releases Jan 17, 2019
@bartekn
Copy link
Contributor Author

bartekn commented Jan 28, 2019

Currently, NETWORK_PASSPHRASE is not required and defaults to test network. This can cause some unexpected behaviour so we should probably remove default value make this field required.

@bartekn bartekn mentioned this issue Jan 28, 2019
Merged
ire-and-curses added a commit that referenced this issue Jan 28, 2019
@ire-and-curses
remove NETWORK_PASSPHRASE default, closes #817
ecac457
@ire-and-curses
Copy link
Member

This was implemented as part of #834.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ire-and-curses ire-and-curses

Labels
help wanted horizon
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bartekn @tomquisel @ire-and-curses